dongjoon-hyun commented on a change in pull request #24686: [SPARK-27813][SQL]
DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r288735439
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2195,4 +2195,22 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
}
}
+ /**
+ * Create a [[sql.DropTableStatement]] command.
+ */
+ override def visitDropTable(ctx: DropTableContext): LogicalPlan =
withOrigin(ctx) {
+ sql.DropTableStatement(
Review comment:
Right. Shall we use import, @jzhuge ?
```
-import
org.apache.spark.sql.catalyst.plans.logical.sql.{CreateTableAsSelectStatement,
CreateTableStatement}
+import
org.apache.spark.sql.catalyst.plans.logical.sql.{CreateTableAsSelectStatement,
CreateTableStatement, DropTableStatement, DropViewStatement}
```
Also, please remove `sql.` from the function comments, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
