Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3939#discussion_r22623112
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -815,13 +804,11 @@ def deploy_files(conn, root_dir, opts, master_nodes, 
slave_nodes, modules):
         cluster_url = "%s:7077" % active_master
     
         if "." in opts.spark_version:
    -        # Pre-built spark & shark deploy
    -        (spark_v, shark_v) = get_spark_shark_version(opts)
    +        # Pre-built Spark deploy
    +        spark_v = opts.spark_version.replace("v", "")
    --- End diff --
    
    @shivaram @JoshRosen Do you know why we allow versions to be passed in as 
`v1.2.0` (with a leading `v`)? Is it safe to remove this option?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to