Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3824#discussion_r22626035
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -758,13 +760,14 @@ private[spark] class Master(
// Event logging is enabled for this application, but no event
logs are found
val title = s"Application history not found (${app.id})"
var msg = s"No event logs found for application $appName in
$eventLogFile."
- logWarning(msg)
+ val exception = URLEncoder.encode(Utils.exceptionString(fnf),
"UTF-8")
+ logWarning(msg, fnf)
msg += " Did you specify the correct logging directory?"
msg = URLEncoder.encode(msg, "UTF-8")
- app.desc.appUiUrl = notFoundBasePath + s"?msg=$msg&title=$title"
+ app.desc.appUiUrl = notFoundBasePath +
s"?msg=$msg&exception=$exception&title=$title"
--- End diff --
I think it's OK to not encode the exception here. This is a file not found
exception so it doesn't convey much extra information.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
