Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/3841#issuecomment-69125434
@andrewor14 `def` would not be enough, as I said before:
> For some port using in SparkEnv, for instance the BlockManager's and
'http file server' port, they will not be able to read spark.port.maxRetries
before env in SparkEnv is set.
Some port will binded while SparkEnv was created. Even we change the
`portMaxRetries` to a `def`, `Option(SparkEnv.get)` will get nothing.
@ash211 In executor side, this patch do send the `spark.port.maxRetries` to
executor with -D flags. Only in driver side, we use a `System.setProperty` to
move `spark.port.maxRetries` from SparkConf to System Properties.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
