dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL]
Add count_if functions
URL: https://github.com/apache/spark/pull/24335#discussion_r291433282
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -894,4 +894,30 @@ class DataFrameAggregateSuite extends QueryTest with
SharedSQLContext {
error.message.contains("function min_by does not support ordering on
type map<int,string>"))
}
}
+
+ test("SPARK-27425: count_if function") {
Review comment:
In general, we don't use SPARK JIRA id for new feature test case name. Could
you remove `SPARK-27425: `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
