peter-toth edited a comment on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#issuecomment-501145852 Thanks @liancheng for the review. I've moved analysis error test cases to `AnalysisSuite` as you suggested. But I left the positive test case in `SQLQuerySuite` as I think the value of `x` column should be tested. Please let me know if you disagree. BTW there is another improvement PR regarding `WITH` clause I opened recently: https://github.com/apache/spark/pull/24831 Any comment is very welcome if you have some time to review it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
