holdenk commented on a change in pull request #24855: [SPARK-28030] convert filePath to URI in binary file data source URL: https://github.com/apache/spark/pull/24855#discussion_r293004219
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala ########## @@ -368,4 +368,14 @@ class BinaryFileFormatSuite extends QueryTest with SharedSQLContext with SQLTest assert(caught.getMessage.contains("exceeds the max length allowed")) } } + + test("SPARK-28030: support chars in file names that require URL encoding") { + withTempDir { dir => Review comment: Is it ok that we only have the space in the file name, or do we need it in the path were providing to trigger SPARK-28030? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org