HyukjinKwon commented on a change in pull request #21696: [SPARK-24716][SQL]
Refactor ParquetFilters
URL: https://github.com/apache/spark/pull/21696#discussion_r293699502
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
##########
@@ -353,38 +353,42 @@ class ParquetFileFormat
(file: PartitionedFile) => {
assert(file.partitionValues.numFields == partitionSchema.size)
- // Try to push down filters when filter push-down is enabled.
- val pushed = if (enableParquetFilterPushDown) {
- filters
- // Collects all converted Parquet filter predicates. Notice that not
all predicates can be
- // converted (`ParquetFilters.createFilter` returns an `Option`).
That's why a `flatMap`
- // is used here.
- .flatMap(new ParquetFilters(pushDownDate, pushDownStringStartWith)
- .createFilter(requiredSchema, _))
- .reduceOption(FilterApi.and)
- } else {
- None
- }
-
val fileSplit =
new FileSplit(new Path(new URI(file.filePath)), file.start,
file.length, Array.empty)
+ val filePath = fileSplit.getPath
Review comment:
@wangyum, when it's easy to reduce the diff, please reduce the diff to make
it easier to track. I think the diff was considerably small if you just move
these three line up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
