ketank-new commented on a change in pull request #24861: [SPARK-26985][CORE]
Fix "access only some column of the all of columns " for big endian
architecture BUG
URL: https://github.com/apache/spark/pull/24861#discussion_r293789619
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
##########
@@ -304,7 +304,7 @@ public static void throwException(Throwable t) {
static {
boolean _unaligned;
String arch = System.getProperty("os.arch", "");
- if (arch.equals("ppc64le") || arch.equals("ppc64")) {
+ if (arch.equals("ppc64le") || arch.equals("ppc64") ||
arch.matches("s390x")) {
Review comment:
> I'm suggesting `.contains` for substring matching. `.matches` is for a
regex.
so should make the file change in this PR itself or do a new PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
