dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI]
Update jquery to 3.4.1
URL: https://github.com/apache/spark/pull/24843#discussion_r294034951
##########
File path: docs/js/main.js
##########
@@ -93,5 +93,5 @@ $(function() {
// Scroll now too in case we had opened the page on a hash, but wait a bit
because some browsers
// will try to do *their* initial scroll after running the onReady handler.
- $(window).load(function() { setTimeout(function() { maybeScrollToHash(); },
25); });
+ $(window).on('load', function() { setTimeout(function() {
maybeScrollToHash(); }, 25); });
Review comment:
Yep. This is the correct update based on the upgrade-guide.
-
https://jquery.com/upgrade-guide/3.0/#breaking-change-load-unload-and-error-removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
