srowen commented on a change in pull request #24702: [SPARK-27989] [Kubernetes] 
[Core] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r294340743
 
 

 ##########
 File path: 
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh
 ##########
 @@ -78,6 +78,16 @@ case "$1" in
       -Xms$SPARK_EXECUTOR_MEMORY
       -Xmx$SPARK_EXECUTOR_MEMORY
       -cp "$SPARK_CLASSPATH"
+     )
+
+    #Disable negative dns reslolution 
https://docs.oracle.com/javase/8/docs/technotes/guides/net/properties.html if 
that property is defined
 
 Review comment:
   I mean that a) I'm not sure we should make this change but if we do, it's b) 
not directly related to the JIRA/PR purpose, which is just to introduce 
retries. I think you're saying there is not much point in retrying unless this 
change happens too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to