srowen commented on a change in pull request #24861: [SPARK-26985][CORE] Fix
"access only some column of the all of columns " for big endian architecture BUG
URL: https://github.com/apache/spark/pull/24861#discussion_r294818167
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
##########
@@ -304,7 +304,7 @@ public static void throwException(Throwable t) {
static {
boolean _unaligned;
String arch = System.getProperty("os.arch", "");
- if (arch.equals("ppc64le") || arch.equals("ppc64")) {
+ if (arch.equals("ppc64le") || arch.equals("ppc64") ||
arch.contains("s390x")) {
Review comment:
@ketank-new it's worth asking, what arch strings are you matching here? i.e.
according to
https://www.ibm.com/support/knowledgecenter/en/SSYKE2_8.0.0/com.ibm.java.80.doc/diag/preface/conventions.html
do you also need to match "s390"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
