Github user WangTaoTheTonic commented on a diff in the pull request:
https://github.com/apache/spark/pull/3607#discussion_r22697386
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
---
@@ -68,8 +68,6 @@ private[spark] class YarnClientSchedulerBackend(
// List of (target Client argument, environment variable, Spark
property)
val optionTuples =
List(
- ("--driver-memory", "SPARK_MASTER_MEMORY", "spark.master.memory"),
- ("--driver-memory", "SPARK_DRIVER_MEMORY", "spark.driver.memory"),
--- End diff --
Since in `Client.scala` the `--driver-memory` passed by spark-submit is not
used anymore.
I thought we've disscussed it before.
>@andrewor14 Ok, I got what you mean. I think I have a misunderstanding
before.
To solve this problem, should we just delete
("--driver-memory", "SPARK_MASTER_MEMORY", "spark.master.memory"),
("--driver-memory", "SPARK_DRIVER_MEMORY", "spark.driver.memory"), .
in YarnClientSchedulerBackend.scala?
>@WangTaoTheTonic that would fix it, but I think in addition to that we
should also add a check in ClientArguments itself in case the user calls into
the Client main class and specifying --driver-memory manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
