itsvikramagr commented on a change in pull request #24922: [SPARK-28120][SS]
Rocksdb state storage implementation
URL: https://github.com/apache/spark/pull/24922#discussion_r296093243
##########
File path: sql/core/pom.xml
##########
@@ -147,6 +147,12 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
+ <!-- RocksDB dependency for Structured Streaming State Store -->
+ <dependency>
+ <groupId>org.rocksdb</groupId>
+ <artifactId>rocksdbjni</artifactId>
Review comment:
I will take a look at the Flink build and see if I can pick only relevant
packages in rocksdb dependency.
IMO, abstracting out how state backend should filter out timed out states
can be treated as a separate problem so that we don't end up increasing the
scope of this PR. Once the abstraction is added, we can file a separate jira to
implement it for rocksdb state backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
