wangyum opened a new pull request #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide URL: https://github.com/apache/spark/pull/24948 ## What changes were proposed in this pull request? We changed our non-standard syntax for `trim` function in #24902 from `TRIM(trimStr, str)` to `TRIM(str, trimStr)` to be compatible with other databases. This pr update the migration guide. I checked various databases(PostgreSQL, Teradata, Vertica, Oracle, DB2, SQL Server 2019, MySQL, Hive, Presto) and it seems that only PostgreSQL and Presto support this non-standard syntax. **PostgreSQL**: ```sql postgres=# select substr(version(), 0, 16), trim('yxTomxx', 'x'); substr | btrim -----------------+------- PostgreSQL 11.3 | yxTom (1 row) ``` **Presto**: ```sql presto> select trim('yxTomxx', 'x'); _col0 ------- yxTom (1 row) ``` ## How was this patch tested? manual tests
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
