Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3431#discussion_r22739718
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
    @@ -18,31 +18,38 @@
     package org.apache.spark.sql.json
     
     import org.apache.spark.sql.SQLContext
    +import org.apache.spark.sql.catalyst.types.StructType
     import org.apache.spark.sql.sources._
     
     private[sql] class DefaultSource extends RelationProvider {
       /** Returns a new base relation with the given parameters. */
       override def createRelation(
           sqlContext: SQLContext,
    -      parameters: Map[String, String]): BaseRelation = {
    +      parameters: Map[String, String],
    +      schema: Option[StructType]): BaseRelation = {
    --- End diff --
    
    Default values do not preserve binary compatibility, only source 
compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to