cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r296983401
##########
File path: core/src/main/scala/org/apache/spark/network/BlockDataManager.scala
##########
@@ -32,6 +32,12 @@ trait BlockDataManager {
*/
def getBlockData(blockId: BlockId): ManagedBuffer
+ /**
+ * Interface to get shuffle block data. Throws an exception if the block
cannot be found or
+ * cannot be read successfully.
+ */
+ def getShuffleBlockData(blockId: BlockId, shuffleGenerationId: Int):
ManagedBuffer
Review comment:
nit: `shuffleGenerationId` should be put before `blockId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
