AngersZhuuuu commented on a change in pull request #24909: [SPARK-28106][SQL]
When Spark SQL use "add jar" , before add to SparkContext, check jar path
exist first.
URL: https://github.com/apache/spark/pull/24909#discussion_r297004428
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1799,6 +1799,20 @@ class SparkContext(config: SparkConf) extends Logging {
// For local paths with backslashes on Windows, URI throws an exception
addJarFile(new File(path))
} else {
+ /**
+ * Check Path valid
+ */
+ val uriPath = new Path(path).toUri
+ val schemeCorrectedPath = uriPath.getScheme match {
+ case null => new File(path).getCanonicalFile.toURI.toString
+ case "local" => "file:" + uriPath.getPath
+ case _ => path
+ }
+ val hadoopPath = new Path(schemeCorrectedPath)
+ val fs = hadoopPath.getFileSystem(hadoopConfiguration)
+ if(!fs.exists(hadoopPath))
+ throw new FileNotFoundException(s"Jar ${schemeCorrectedPath} not
found")
Review comment:
@jerryshao I was to focused on SQL engine. you said is right. Maybe I
should check more with @srowen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
