cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r298047004
##########
File path:
core/src/test/scala/org/apache/spark/shuffle/sort/IndexShuffleBlockResolverSuite.scala
##########
@@ -155,4 +156,19 @@ class IndexShuffleBlockResolverSuite extends
SparkFunSuite with BeforeAndAfterEa
indexIn2.close()
}
}
+
+ test("commit shuffle files multiple times") {
+ val shuffleId = 1
+ val mapId = 2
+ val idxName = s"shuffle_${shuffleId}_${mapId}_0.index"
+ testWithIndexShuffleBlockResolver(shuffleId, mapId, idxName, -1)
+ }
+
+ test("commit shuffle files with shuffle generation id multiple times") {
Review comment:
shall we also test committing shuffle files multiple times with different
shuffle generation ids?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
