Tonix517 commented on a change in pull request #24994: [SPARK-28133] Adding inverse hyperbolic functions in SQL URL: https://github.com/apache/spark/pull/24994#discussion_r299575256
########## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ########## @@ -2023,11 +2041,29 @@ object functions { /** * @param columnName hyperbolic angle - * @return hyperbolic sine of the given value, as if computed by `java.lang.Math.sinh` + * @return inverse hyperbolic sine of the given value * * @group math_funcs - * @since 1.4.0 + * @since 3.0.0 */ + def asinh(columnName: String): Column = asinh(Column(columnName)) Review comment: Hi @HyukjinKwon, do you mean we remove then from R for the same reason we removed them from Python, and just keep them in Scala? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org