maropu commented on a change in pull request #25001: [SPARK-28083][SQL] Support
LIKE ... ESCAPE syntax
URL: https://github.com/apache/spark/pull/25001#discussion_r300517573
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1240,7 +1240,9 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case SqlBaseParser.IN =>
invertIfNotDefined(In(e, ctx.expression.asScala.map(expression)))
case SqlBaseParser.LIKE =>
- invertIfNotDefined(Like(e, expression(ctx.pattern)))
+ val escapeOpt = Option(ctx.escapeChar).map(_.getText)
+ val like = Like(e, expression(ctx.pattern), escapeOpt)
+ invertIfNotDefined(like)
Review comment:
Needs to check if `escapeOpt` has a valid char for an escape ?
In PostgreSQL;
```
postgres=# select * from t where a like 'a%c' escape 'invalid';
ERROR: invalid escape string
HINT: Escape string must be empty or one character.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
