Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/4002#discussion_r22787018
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ParallelCollectionRDD.scala ---
@@ -127,18 +127,12 @@ private object ParallelCollectionRDD {
})
}
seq match {
- case r: Range.Inclusive => {
- val sign = if (r.step < 0) {
- -1
- } else {
- 1
- }
- slice(new Range(
- r.start, r.end + sign, r.step).asInstanceOf[Seq[T]], numSlices)
- }
case r: Range => {
- positions(r.length, numSlices).map({
- case (start, end) =>
+ val sign = r.isInclusive && (r.end == Int.MaxValue || r.end ==
Int.MinValue)
--- End diff --
Try to convert this inclusive range
```
-2 to Int.MinValue by -1
```
to exclusive range will be
```
-2L until -1L + Int.MinValue by -1
```
-1 + Int.MinValue will overflow.
As for sign, which name would you recommend? How about
inclusiveRangeWithIntBoundary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
