dongjoon-hyun commented on a change in pull request #25000: [SPARK-28107][SQL]
Support 'day to hour', 'day to minute', 'hour to minute' and 'minute to second'
URL: https://github.com/apache/spark/pull/25000#discussion_r300810723
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -1180,12 +1180,34 @@ class SQLQuerySuite extends QueryTest with
SQLTestUtils with TestHiveSingleton {
test("Convert hive interval term into Literal of CalendarIntervalType") {
checkAnswer(sql("select interval '10-9' year to month"),
Row(CalendarInterval.fromString("interval 10 years 9 months")))
+ checkAnswer(sql("select interval '20 15:40:32.99899999' day to hour"),
+ Row(CalendarInterval.fromString("interval 2 weeks 6 days 15 hours")))
+ checkAnswer(sql("select interval '20 15:40:32.99899999' day to minute"),
+ Row(CalendarInterval.fromString("interval 2 weeks 6 days 15 hours 40
minutes")))
checkAnswer(sql("select interval '20 15:40:32.99899999' day to second"),
Row(CalendarInterval.fromString("interval 2 weeks 6 days 15 hours 40
minutes " +
"32 seconds 99 milliseconds 899 microseconds")))
+ checkAnswer(sql("select interval '15:40:32.99899999' hour to minute"),
+ Row(CalendarInterval.fromString("interval 15 hours 40 minutes")))
+ checkAnswer(sql("select interval '15:40.99899999' hour to second"),
+ Row(CalendarInterval.fromString("interval 15 minutes 40 seconds 99
milliseconds " +
+ "899 microseconds")))
+ checkAnswer(sql("select interval '15:40' hour to second"),
+ Row(CalendarInterval.fromString("interval 15 hours 40 minutes")))
checkAnswer(sql("select interval '15:40:32.99899999' hour to second"),
Row(CalendarInterval.fromString("interval 15 hours 40 minutes 32 seconds
99 milliseconds " +
"899 microseconds")))
+ checkAnswer(sql("select interval '20 40:32.99899999' minute to second"),
+ Row(CalendarInterval.fromString("interval 2 weeks 6 days 40 minutes 32
seconds " +
+ "99 milliseconds 899 microseconds")))
+ checkAnswer(sql("select interval '40:32.99899999' minute to second"),
+ Row(CalendarInterval.fromString("interval 40 minutes 32 seconds 99
milliseconds " +
+ "899 microseconds")))
+ checkAnswer(sql("select interval '40:32.99899999' minute to second"),
+ Row(CalendarInterval.fromString("interval 40 minutes 32 seconds 99
milliseconds " +
+ "899 microseconds")))
Review comment:
Line 1203 ~ 1205 are the same with line 1206 ~ 1208.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
