HyukjinKwon edited a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-508891339 @brkyvz and @cloud-fan, this PR targets to fix SPARK-28153. If the suggestions can fix other corner cases I am not aware of commonly, we should fix everywhere else that uses thread local like that, for instance, https://github.com/apache/spark/blob/5264164a67df498b73facae207eda12ee133be7d/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/EpochTracker.scala#L26-L31 Currently I am not sure which case the new suggestion will fix and cover. I would like to avoid to refactor it by a vague concern but without knowing which bugs we fix. Can we target it in a different ticket if this is correct?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
