viirya commented on a change in pull request #24637: [SPARK-27707][SQL] Prune
unnecessary nested fields from Generate in explode
URL: https://github.com/apache/spark/pull/24637#discussion_r300818212
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -588,6 +588,16 @@ object ColumnPruning extends Rule[LogicalPlan] {
.map(_._2)
p.copy(child = g.copy(child = newChild, unrequiredChildIndex =
unrequiredIndices))
+ // prune unrequired nested fields
+ case p @ Project(projectList, g: Generate) =>
Review comment:
`nestedSchemaPruning` is vague as it can point to nested pruning in scan, or
general nested pruning in other operators. Currently the config affects scan
nested pruning. I feel it is not tightly related to the fix here, because the
fix isn't for scan.
If we are considering a config here, I think a different config or fix the
doc of `nestedSchemaPruning` to explicitly indicate it also helps general
nested pruning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
