dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS]
Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end
users
URL: https://github.com/apache/spark/pull/24996#discussion_r300838883
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
##########
@@ -27,3 +32,34 @@ import org.apache.spark.sql.streaming.Trigger
@Experimental
@Evolving
case object OneTimeTrigger extends Trigger
+
+/**
+ * A [[Trigger]] that runs a query periodically based on the processing time.
If `interval` is 0,
+ * the query will run as fast as possible.
+ */
+@Evolving
+private[sql] case class ProcessingTimeTrigger(intervalMs: Long) extends
Trigger {
Review comment:
Ur, moving looks okay, but the new deprecation of `OneTimeTrigger` is
unexpected one for me.
```
@deprecated("use Trigger.Once()", "3.0.0")
// NOTE: In later release, we can change this to `private[sql]` and remove
deprecated.
case object OneTimeTrigger extends Trigger
```
Please make another PR for the deprecation of `OneTimeTrigger` if we really
need that.
If the PR has multiple themes unexpectedly, we cannot merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
