Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/3655#issuecomment-69684611
Hi @harishreedharan , After carefully looking at the code, I think data
will not be lost even in such failure situation. For example, if we meet
exception in `onPushBlock` which is called in
`BlockGenerator#keepPushingBlocks`, this function will catch the exception and
call `reportError` to notify the exception, After that the thread of
`blockPushingThread` is exited. So there's no chance to call `onPushBlock`
again, in another words, `storeBlockAndCommitOffset` will not be called again,
so offset will not be committed to ZK from the failure point.
And the receiving thread will keep getting data and pushed into
`blockForPushing` until it is full, after that, the whole receiver system is
blocked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
