Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3916#discussion_r22841706
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/PySparkLauncher.java ---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.launcher;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+
+/**
+ * Launcher for PySpark.
+ * <p/>
+ * Handles parsing command line options passed to the pyspark script. This
allows
+ * sharing that logic with other launchers, to keep them in sync.
+ */
+class PySparkLauncher extends AbstractLauncher<PySparkLauncher> {
+
+ private final List<String> args;
+
+ PySparkLauncher(List<String> args) {
+ this.args = args;
+ }
+
+ @Override
+ protected List<String> buildLauncherCommand() throws IOException {
+ SparkSubmitCliLauncher launcher = new SparkSubmitCliLauncher(true,
args);
+
+ // For backwards compatibility, if a script is specified in
+ // the pyspark command line, then run it using spark-submit.
+ if (!launcher.getArgs().isEmpty() &&
launcher.getArgs().get(0).endsWith(".py")) {
+ System.err.println(
+ "WARNING: Running python applications through 'pyspark' is
deprecated as of Spark 1.0.\n" +
+ "Use ./bin/spark-submit <python file>");
+ return launcher.buildLauncherCommand();
+ }
+
+ // When launching the pyspark shell, the spark-submit arguments should
be stored in the
+ // PYSPARK_SUBMIT_ARGS env variable. The executable is the
PYSPARK_DRIVER_PYTHON env variable
+ // set by the pyspark script, followed by PYSPARK_DRIVER_PYTHON_OPTS.
+ checkArgument(launcher.getArgs().isEmpty(),
+ "pyspark does not support any application options.");
--- End diff --
unindent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
