dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] 
Use ConfigEntry for hardcoded configs in SQL
URL: https://github.com/apache/spark/pull/25059#discussion_r302302154
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
 ##########
 @@ -665,17 +666,17 @@ abstract class SQLViewSuite extends QueryTest with 
SQLTestUtils {
         sql(s"CREATE VIEW view${idx + 1} AS SELECT * FROM view$idx")
       }
 
-      withSQLConf("spark.sql.view.maxNestedViewDepth" -> "10") {
+      withSQLConf(SQLConf.MAX_NESTED_VIEW_DEPTH.key -> "10") {
 
 Review comment:
   ```
   -      withSQLConf(SQLConf.MAX_NESTED_VIEW_DEPTH.key -> "10") {
   +      withSQLConf(MAX_NESTED_VIEW_DEPTH.key -> "10") {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to