maropu commented on a change in pull request #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r302331201
########## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ########## @@ -1190,7 +1183,9 @@ SELECT * FROM parent; --DROP RULE y_rule ON y; -- check that parser lookahead for WITH doesn't cause any odd behavior +-- [TODO] WITH should be a reserved keyword? Review comment: yea, already reaserved in spark (ansi=true). https://github.com/apache/spark/blob/master/docs/sql-keywords.md ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
