AngersZhuuuu commented on issue #25071: [SPARK-28292][SQL] Enable inject 
user-defined Hint
URL: https://github.com/apache/spark/pull/25071#issuecomment-510289811
 
 
   > @AngersZhuuuu . The regression test is used to protect your patch. Without 
that, your contribution can be disabled accidentally in the future. :)
   > 
   > > By the way , this pr has been used well in our prod
   
   I know it,。
   I'm not familiar with the unit tests about spark, so sometimes it takes time 
to find the right place and way to write unit tests。I am learning how to write  
good unit tests for these

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to