Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/4004#issuecomment-69796504
@guowei2 Based on comments of `DecimalPrecision`, it looks like it is used
to handle all fixed-precision decimals related type operations. I think we can
have less number of changes by just updating `DecimalPrecision`. The code can
be easier to read since logics related to fixed-precision decimals are in a
single place. Also, you may want to use `DecimalPrecisionSuite` for your unit
tests. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
