brkyvz commented on a change in pull request #24937: [SPARK-28139][SQL] Add v2
ALTER TABLE implementation.
URL: https://github.com/apache/spark/pull/24937#discussion_r302698140
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -353,6 +354,59 @@ trait CheckAnalysis extends PredicateHelper {
case _ =>
}
+ case alter: AlterTable if alter.childrenResolved =>
Review comment:
Is there a reason that some of these checks are here, and some in the
`resolved` of AlterTable? It'd be nice to hide the complexity inside AlterTable
if possible, and do a simpler check here on whether AlterTable is `resolved`.
However, I would much prefer the case where we can throw a better error
message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
