gaborgsomogyi commented on a change in pull request #25135: [SPARK-28367][SS]
Use new KafkaConsumer.poll API in Kafka connector
URL: https://github.com/apache/spark/pull/25135#discussion_r303346517
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -310,6 +309,20 @@ class KafkaTestUtils(withBrokerProps: Map[String, Object]
= Map.empty) extends L
offsets
}
+ private def getPartitions(consumer: KafkaConsumer[String, String]):
JSet[TopicPartition] = {
Review comment:
Originally I was thinking about to move it but not big fan of static
functions. Let me check what can we do or where...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
