xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL]
Support DELETE in DataSource V2
URL: https://github.com/apache/spark/pull/25115#discussion_r303356760
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala
##########
@@ -163,6 +187,7 @@ case class IsNotNull(attribute: String) extends Filter {
*/
@Stable
case class And(left: Filter, right: Filter) extends Filter {
+ override def sql: String = s"${left.sql} AND ${right.sql}"
Review comment:
@HyukjinKwon , I'm doubt if I understand you correctly. Can you explain more
about "it won't work with the combinations of `AND` and `OR`. `a OR b AND C`"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
