brkyvz commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-511937029 I don't like large PRs either, but I also think that you can't build good abstractions before you have valid use cases for them. A good split may have been to implement RTAS in this PR, and then split the staged catalog and the atomic implementations to a follow up. I don't see too much worth in splitting them up now that we all have made multiple passes of review on this though. On Tue, Jul 16, 2019, 2:11 PM mccheah <notificati...@github.com> wrote: > We can also break this out into a REPLACE TABLE and then a separate REPLACE > TABLE AS SELECT PR, but that might create more friction than it's worth > what with having to merge multiple PRs and all. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/24798?email_source=notifications&email_token=ABIAE64ZXIQSFX36OLUY54TP7YFM7A5CNFSM4HTG23F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2BV5JY#issuecomment-511925927>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABIAE64NHB5FTE5O5THJK6LP7YFM7ANCNFSM4HTG23FQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
