Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3233#discussion_r22941573
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -277,17 +279,23 @@ private[spark] class Executor(
        * created by the interpreter to the search path
        */
       private def createClassLoader(): MutableURLClassLoader = {
    +    // Bootstrap the list of jars with the user class path.
    +    val now = System.currentTimeMillis()
    +    userClassPath.foreach { url =>
    +      currentJars(url.getPath().split("/").last) = now
    +    }
    +
         val currentLoader = Utils.getContextOrSparkClassLoader
     
         // For each of the jars in the jarSet, add them to the class loader.
         // We assume each of the files has already been fetched.
    -    val urls = currentJars.keySet.map { uri =>
    +    val urls = userClassPath ++ currentJars.keySet.map { uri =>
           new File(uri.split("/").last).toURI.toURL
    -    }.toArray
    --- End diff --
    
    can we keep the toArray here rather then having to do it in 2 places below?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to