dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r304997464
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ########## @@ -1243,6 +1249,24 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging IsNotNull(e) case SqlBaseParser.NULL => IsNull(e) + case SqlBaseParser.TRUE if ctx.NOT != null => + checkBooleanTestArgs(e) + Not(BooleanTest(e, Some(true))) + case SqlBaseParser.TRUE => + checkBooleanTestArgs(e) + BooleanTest(e, Some(true)) + case SqlBaseParser.FALSE if ctx.NOT != null => + checkBooleanTestArgs(e) + Not(BooleanTest(e, Some(false))) + case SqlBaseParser.FALSE => + checkBooleanTestArgs(e) + BooleanTest(e, Some(false)) + case SqlBaseParser.UNKNOWN if ctx.NOT != null => + checkBooleanTestArgs(e) + Not(BooleanTest(e, None)) Review comment: Ping, @beliefer . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org