Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22955597
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Date.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.types
+
+import java.util.{Calendar, TimeZone}
+
+import org.apache.spark.sql.catalyst.expressions.Cast
+
+/**
+ * A mutable implementation of java.sql.Date that holds an Int for days
since epoch, like Hive.
+ */
+final class Date extends Ordered[Date] with Serializable {
+ private var daysSinceEpoch: Int = 0
+
+ /**
+ * Set this Date to the given Int (days since 1970-01-01).
+ */
+ def set(days: Int): Date = {
+ this.daysSinceEpoch = days
+ this
+ }
+
+ /**
+ * Set this Date to the given type.Date value.
+ */
+ def set(date: Date): Date = {
+ this.daysSinceEpoch = date.daysSinceEpoch
+ this
+ }
+
+ /**
+ * Get the Int value of days since 1970-01-01.
+ */
+ def toDays: Int = {
+ this.daysSinceEpoch
+ }
+
+ /**
+ * get the corresponding java.sql.Date value of this Date object.
+ */
+ def toJavaDate: java.sql.Date = {
+ new java.sql.Date(toLong)
+ }
+
+ override def toString: String =
Cast.threadLocalDateFormat.get.format(toJavaDate)
+
+ def toLong: Long = {
--- End diff --
rename this
toMillisSinceEpoch ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
