maropu commented on a change in pull request #25001: [SPARK-28083][SQL] Support
LIKE ... ESCAPE syntax
URL: https://github.com/apache/spark/pull/25001#discussion_r305181626
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -484,6 +484,8 @@ class SQLQueryTestSuite extends QueryTest with
SharedSQLContext {
""".stripMargin)
.load(testFile("test-data/postgresql/tenk.data"))
.createOrReplaceTempView("tenk1")
+
+ session.sql("select * from tenk1 where stringu1 like stringu2 escape
'\"'")
Review comment:
This is not correct and I meant we need test s in
`resources/sql-tests/inputs/`. Or, to check if the parser works well for the
new token `ESCAPE`, its ok to add tests in `ExpressionParserSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
