Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4029#discussion_r22963362
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -58,6 +58,7 @@ case class SparkListenerTaskEnd(
     @DeveloperApi
     case class SparkListenerJobStart(
         jobId: Int,
    +    time: Option[Long],
    --- End diff --
    
    I guess this is an option for backwards-compatibility reasons?  We 
definitely know the time when posting this event to the listener bus, so I 
think the right approach is to have time just be a regular `Long` and pass a 
dummy value (`-1`) when replaying JSON that's missing that field.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to