Github user ksakellis commented on a diff in the pull request:
https://github.com/apache/spark/pull/4051#discussion_r22972821
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala ---
@@ -73,12 +73,12 @@ private[spark] class ClientArguments(args:
Array[String], sparkConf: SparkConf)
.orNull
// If dynamic allocation is enabled, start at the max number of
executors
if (isDynamicAllocationEnabled) {
- val maxExecutorsConf = "spark.dynamicAllocation.maxExecutors"
- if (!sparkConf.contains(maxExecutorsConf)) {
+ val minExecutorsConf = "spark.dynamicAllocation.maxExecutors"
+ if (!sparkConf.contains(minExecutorsConf)) {
--- End diff --
so the ExecutorAllocationManager already validates that minExecutorConf
exists and is valid (not negative and non-zero). Do we need this? or are we
being paranoid? If so, maybe an assertion is better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
