albertusk95 commented on a change in pull request #25107: [SPARK-28344][SQL]
detect ambiguous self-join and fail the query
URL: https://github.com/apache/spark/pull/25107#discussion_r305573273
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -787,6 +787,13 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val FAIL_AMBIGUOUS_SELF_JOIN =
+ buildConf("spark.sql.analyzer.failAmbiguousSelfJoin")
+ .doc("When true, fail the Dataset query if it contains ambiguous
self-join.")
+ .internal()
+ .booleanConf
+ .createWithDefault(true)
+
// Whether to retain group by columns or not in GroupedData.agg.
Review comment:
I think moving this comment to `.doc()` like the above is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
