MaxGekk commented on a change in pull request #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#discussion_r305592937
########## File path: R/pkg/R/functions.R ########## @@ -34,6 +34,17 @@ NULL #' df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))} NULL +#' Make date time functions +#' +#' @param year The year to represent, from 1 to 9999 +#' @param month The month-of-year to represent, from 1 (January) to 12 (December) +#' @param day The day-of-month to represent, from 1 to 31 +#' +#' @name make_datetime_functions +#' @rdname make_datetime_functions +#' @family data time functions +NULL Review comment: I am going to add at least one more function `make_timestamp` with the same parameters + `hour`, `min`, `sec` in another PR. Should I add a separate `@family` like: ``` @family make datetime functions ``` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
