dongjoon-hyun commented on a change in pull request #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#discussion_r305606998
########## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/date.sql ########## @@ -351,13 +351,13 @@ SELECT f1 - date '2000-01-01' AS `Days From 2K` FROM DATE_TBL; -- skip test constructors -- test constructors --- select make_date(2013, 7, 15); --- select make_date(-44, 3, 15); +select make_date(2013, 7, 15); +select make_date(-44, 3, 15); -- select make_time(8, 20, 0.0); -- should fail --- select make_date(2013, 2, 30); --- select make_date(2013, 13, 1); --- select make_date(2013, 11, -1); +select make_date(2013, 2, 30); +select make_date(2013, 13, 1); +select make_date(2013, 11, -1); -- select make_time(10, 55, 100.1); -- select make_time(24, 0, 2.1); Review comment: ditto. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
