Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-70036427
btw, while you're mucking around in there ... it might be nice to change
the `SpecificMutableRow` constructor to take varargs. Change this constructor:
```
- def this(dataTypes: Seq[DataType]) =
+ def this(dataTypes: DataType*) =
```
and then just get rid of the other constructor:
```
- def this() = this(Seq.empty)
-
```
that way you don't have to wrap those types with a `Seq`, eg. instead of
`new SpecificMutableRow(Seq(StringType [, IntType, ...]))` you can just do `new
SpecificMutableRow(StringType [, IntType,...])`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
