cloud-fan commented on a change in pull request #25040: [SPARK-28238][SQL]
Implement DESCRIBE TABLE for Data Source V2 Tables.
URL: https://github.com/apache/spark/pull/25040#discussion_r306591887
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -237,6 +237,9 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
Nil
}
+ case DescribeTable(catalog, ident, _, isExtended) =>
+ DescribeTableExec(catalog, ident, isExtended) :: Nil
Review comment:
how about
```
case DescribeTable(catalog, ident, r: DataSourceV2Relation, isExtended) =>
DescribeTableExec(r.table, ident, isExtended) :: Nil
```
Then we don't need to lookup the table again in `DescribeTableExec`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
