Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3571#discussion_r23036936
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 
---
    @@ -523,10 +525,31 @@ private[spark] object Worker extends Logging {
         val securityMgr = new SecurityManager(conf)
         val (actorSystem, boundPort) = AkkaUtils.createActorSystem(systemName, 
host, port,
           conf = conf, securityManager = securityMgr)
    -    val masterAkkaUrls = masterUrls.map(Master.toAkkaUrl)
    +    val masterAkkaUrls = masterUrls.map(Master.toAkkaUrl(_, conf))
         actorSystem.actorOf(Props(classOf[Worker], host, boundPort, webUiPort, 
cores, memory,
           masterAkkaUrls, systemName, actorName,  workDir, conf, securityMgr), 
name = actorName)
         (actorSystem, boundPort)
       }
     
    +  private[spark] def isUseLocalNodeSSLConfig(cmd: Command): Boolean = {
    +    val pattern = """\-Dspark\.ssl\.useNodeLocalConf\=(.+)""".r
    +    val result = cmd.javaOpts.collectFirst {
    +      case pattern(_result) => _result.toBoolean
    +    }
    +    result.getOrElse(false)
    +  }
    +
    +  private[spark] def maybeUpdateSSLSettings(cmd: Command, conf: 
SparkConf): Command = {
    +    val prefix = "spark.ssl."
    +    val useLNCPrefix = "spark.ssl.useNodeLocalConf"
    --- End diff --
    
    nit: for consistency, append `.` to the prefix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to