srowen commented on a change in pull request #25230: [SPARK-28471][SQL] Replace 
`yyyy` by `uuuu` in date-timestamp patterns without era
URL: https://github.com/apache/spark/pull/25230#discussion_r306782685
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/results/pgSQL/date.sql.out
 ##########
 @@ -520,7 +520,7 @@ select make_date(-44, 3, 15)
 -- !query 48 schema
 struct<make_date(-44, 3, 15):date>
 -- !query 48 output
-0045-03-15
+-0044-03-15
 
 Review comment:
   Interesting, so postgres had a different answer here? also shouldn't the 
year be negative in this output or do I misunderstand?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to