Github user squito commented on the pull request:

    https://github.com/apache/spark/pull/4048#issuecomment-70181484
  
    so, this doesn't actually work quite the way I wanted it to.  It turns out 
its skipping all the Junit tests as well.  The junit tests are run if you run 
with `test-only * -- -l`, but as sound as you add a tag like `test-only * -- -l 
foo`, then all the junit tests are skipped.  From the [junit-interface 
docs](https://github.com/sbt/junit-interface) "Any parameter not starting with 
- or + is treated as a glob pattern for matching tests."
    
    I will look into a solution for this, but I have a feeling this might mean 
we can't mix junit w/ the tagging approach, and we have to go to a more 
standard directory / filenaming approach to separating out integration tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to